Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of LTS in Volto #4905

Merged
merged 4 commits into from Nov 22, 2023
Merged

Remove mention of LTS in Volto #4905

merged 4 commits into from Nov 22, 2023

Conversation

stevepiercy
Copy link
Collaborator

@stevepiercy stevepiercy commented Jun 22, 2023

Fixes #4904

@netlify
Copy link

netlify bot commented Jun 22, 2023

Deploy Preview for volto ready!

Name Link
🔨 Latest commit 36b95c4
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/655c65abc714fa000955aeb6
😎 Deploy Preview https://deploy-preview-4905--volto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Jun 22, 2023

Passing run #5848 ↗︎

0 503 20 0 Flakiness 0

Details:

Add change log entry
Project: Volto Commit: d88c9f6663
Status: Passed Duration: 13:09 💡
Started: Jun 22, 2023 10:05 PM Ended: Jun 22, 2023 10:18 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Sponsor Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me, but it is up to Victor.

One way that we could still regard Volto 16 as LTS, is when we make Volto 17 a developer/unstable release to try new things out, and then Volto 18 a stable LTS release again, like node and Linux do: uneven versions are unstable, even are stable. I think this idea was floated briefly during the Beethovensprint, but Volto has not done this so far, and I don't think it will. Unless this changes, LTS seems not an ideal term.

tisto
tisto previously requested changes Jun 23, 2023
Copy link
Sponsor Member

@tisto tisto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments: #4901 (comment)

@stevepiercy
Copy link
Collaborator Author

Do we have a decision on using the term "LTS"?

@sneridagh
Copy link
Member

@stevepiercy not yet, I don't expect this to happen before we see each other again in the PC I'd say...

Copy link
Member

@sneridagh sneridagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, and for the record, I approve this.

@stevepiercy stevepiercy mentioned this pull request Nov 4, 2023
@stevepiercy stevepiercy dismissed tisto’s stale review November 22, 2023 09:50

@tisto's comments do not require the use of the term "LTS". It was agreed to use our more accurate description of support and maintainence.

@stevepiercy stevepiercy merged commit 44be7cc into main Nov 22, 2023
52 checks passed
@stevepiercy stevepiercy deleted the docs-remove-lts-mention branch November 22, 2023 09:50
sneridagh added a commit that referenced this pull request Nov 30, 2023
* main:
  Move dangling news item to the right place
  Better start script in root package.json, enable and better config for husky/lint-staged
  All in with monorepo (#5409)
  changed toNumber to parseFloat   #5447 (#5448)
  Release 18.0.0-alpha.3
  Changelog
  Revert "Improvements and completeness of the ContentMetadataTags component (#5433)" (#5449)
  Update yarnhook to 0.6.1 in order to support pnpm 8 (#5444)
  Special breadcrumb in controlpanel (#5292)
  Adding extraction of videoID from youtube videos url which contain '/live/' (#5426)
  Release 18.0.0-alpha.2
  Release generate-volto 8.0.3
  Changelog
  Bring back yeoman install which in v5 is deprecated (#5438)
  Improvements and completeness of the ContentMetadataTags component (#5433)
  Use container from component registry in sitemap component and also refactor the class to functional component(#5418) (#5420)
  Fix image paths in development mode (#5429)
  Visible focus semantic UI - reset (#5335)
  Remove mention of LTS in Volto (#4905)
  JSX is now in Pygments (#5412)
sneridagh added a commit that referenced this pull request Nov 30, 2023
* main: (21 commits)
  Cleanup and renaming (#5456)
  Move dangling news item to the right place
  Better start script in root package.json, enable and better config for husky/lint-staged
  All in with monorepo (#5409)
  changed toNumber to parseFloat   #5447 (#5448)
  Release 18.0.0-alpha.3
  Changelog
  Revert "Improvements and completeness of the ContentMetadataTags component (#5433)" (#5449)
  Update yarnhook to 0.6.1 in order to support pnpm 8 (#5444)
  Special breadcrumb in controlpanel (#5292)
  Adding extraction of videoID from youtube videos url which contain '/live/' (#5426)
  Release 18.0.0-alpha.2
  Release generate-volto 8.0.3
  Changelog
  Bring back yeoman install which in v5 is deprecated (#5438)
  Improvements and completeness of the ContentMetadataTags component (#5433)
  Use container from component registry in sitemap component and also refactor the class to functional component(#5418) (#5420)
  Fix image paths in development mode (#5429)
  Visible focus semantic UI - reset (#5335)
  Remove mention of LTS in Volto (#4905)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove any mention of LTS
4 participants