Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bundlewatch to 0.3.3 #4967

Merged
merged 2 commits into from Jul 14, 2023
Merged

Upgrade bundlewatch to 0.3.3 #4967

merged 2 commits into from Jul 14, 2023

Conversation

wesleybl
Copy link
Member

This is needed to update axios and avoid vulnerabilities in axios < 0.21.3. See:

https://security.snyk.io/package/npm/axios

This is needed to update axios and avoid vulnerabilities in axios <
0.21.3. See:

https://security.snyk.io/package/npm/axios
@netlify
Copy link

netlify bot commented Jul 12, 2023

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 3af56e5
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/64b145d090371c00080d9c0b

@cypress
Copy link

cypress bot commented Jul 12, 2023

Passing run #6335 ↗︎

0 515 20 0 Flakiness 0

Details:

Move bundlewatch to devDependencies
Project: Volto Commit: 3af56e528f
Status: Passed Duration: 14:54 💡
Started: Jul 14, 2023 12:58 PM Ended: Jul 14, 2023 1:13 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Sponsor Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but we should move this to devDependencies. There's no reason to require everyone using volto to install a package that is used as an aid for development of volto.

@wesleybl
Copy link
Member Author

This looks fine, but we should move this to devDependencies.

@davisagli done.

@davisagli davisagli merged commit 454eee9 into master Jul 14, 2023
53 checks passed
@davisagli davisagli deleted the bundlewatch branch July 14, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants