Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'external' className to Universal link component for external link. #5109

Closed
iFlameing opened this issue Aug 22, 2023 · 3 comments
Closed

Add 'external' className to Universal link component for external link. #5109

iFlameing opened this issue Aug 22, 2023 · 3 comments
Labels
04 type: enhancement

Comments

@iFlameing
Copy link
Member

No description provided.

@codewithmurali
Copy link

codewithmurali commented Sep 8, 2023 •
edited

Hey Flameing, Can you elaborate on your issue?

@ThisisMS11
Copy link

image

is this where i have to make the necessary changes. Please help me figure out where to make the changes and what is meant by add 'external' className to universal link component .

image

does it mean that i need to change the default prop value of className i.e NULL To 'external' . please give a explanation .
I am new to the open source world and I am looking for to make my first pull request in plone .

@davisagli
Copy link
Sponsor Member

@ThisisMS11 This was already done in #5110 and #5188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
04 type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@davisagli @iFlameing @codewithmurali @ThisisMS11