Fix load addon translations: last addon translations wins #5113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volto ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Passing run #6987 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
erral
approved these changes
Aug 23, 2023
stevepiercy
requested changes
Aug 23, 2023
stevepiercy
requested changes
Aug 23, 2023
Co-authored-by: Steve Piercy <web@stevepiercy.com>
sneridagh
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
LGTM, but I'd like @davisagli and @danalvrz to take a look first, since they were the last that touched that the last time (I think for a similar problem).
davisagli
requested changes
Aug 23, 2023
Co-authored-by: David Glick <david@glicksoftware.com>
stevepiercy
requested changes
Aug 24, 2023
Co-authored-by: Steve Piercy <web@stevepiercy.com>
stevepiercy
approved these changes
Aug 24, 2023
davisagli
approved these changes
Aug 24, 2023
sneridagh
pushed a commit
that referenced
this pull request
Aug 25, 2023
Co-authored-by: Steve Piercy <web@stevepiercy.com> Co-authored-by: David Glick <david@glicksoftware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.