Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] configuration > volto-slate needs updates #5342

Closed
stevepiercy opened this issue Oct 26, 2023 · 5 comments · Fixed by #5886
Closed

[docs] configuration > volto-slate needs updates #5342

stevepiercy opened this issue Oct 26, 2023 · 5 comments · Fixed by #5886

Comments

@stevepiercy
Copy link
Collaborator

stevepiercy commented Oct 26, 2023

volto-slate is now in core. The page volto-slate is now out of date.

With the exception of Release Notes and the Upgrade Guide, anything that indicates volto-slate not being in core needs to be updated to it now being in core. Documentation was never updated when that happened back in v16.

No one has done a comprehensive search to identify files that need to be updated. It's not a simple find-and-replace. For example, on volto-slate:

Although this add-on is in an early alpha stage

It's not in alpha any more. It was added in Volto 16.0.0-alpha.15. This page should have similar admonitions copied from the Upgrade Guide.

@MostafaMagdyy
Copy link
Contributor

MostafaMagdyy commented Mar 11, 2024

Hey, are there any other documents that need to be updated regarding Slate being integrated into the core of Volto?

As I currently see in volto-slate, volto-slate is an interactive default text editor for Volto. If there is, I want to contribute to this issue.

@stevepiercy
Copy link
Collaborator Author

@MostafaMagdyy please read and follow First-time contributors, Contributing to Plone, and Contributing to Volto. For docs only, I would recommend the setup in Building and checking the quality of documentation.

I've updated the issue description with more information.

@MostafaMagdyy
Copy link
Contributor

MostafaMagdyy commented Mar 12, 2024

Thank you. I have signed the Plone Contributor Agreement and am currently waiting to make a PR regarding this issue.

@MostafaMagdyy
Copy link
Contributor

MostafaMagdyy commented Mar 15, 2024

@stevepiercy I'm currently encountering an issue while attempting to push my commits for this issue. The error message states.
remote: Permission to plone/volto.git denied to MostafaMagdyy
while i am in this step
Plone

@Contributing to documentation
Despite having signed the Plone Contributor Agreement, I created an access token for authentication, which has been pending admin approval for the past two days.

Should I contribute directly to the volto/plone repository, or should I follow the guidelines outlined in the section for external packages in Contributing to documentation ?

When I follow the instructions for external packages, I encounter the issue mentioned above.

Could you provide guidance on the correct procedure or any additional steps I should take? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants