Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve restricted key in blocks config to include navRoot and contentType #5517

Merged
merged 7 commits into from Dec 13, 2023

Conversation

sneridagh
Copy link
Member

No description provided.

Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for volto ready!

Name Link
🔨 Latest commit 2b53702
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/6579664e92e15200085105bf
😎 Deploy Preview https://deploy-preview-5517--volto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing docs only. These are great! Minor tweaks to grammar, and they're good to go. Thank you!

docs/source/recipes/howtorestrictblocks.md Outdated Show resolved Hide resolved
docs/source/recipes/howtorestrictblocks.md Outdated Show resolved Hide resolved
docs/source/recipes/howtorestrictblocks.md Outdated Show resolved Hide resolved
docs/source/recipes/howtorestrictblocks.md Outdated Show resolved Hide resolved
docs/source/recipes/howtorestrictblocks.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good. Simplified change log entries.

packages/volto-slate/news/5517.feature Outdated Show resolved Hide resolved
packages/volto/news/5517.feature Outdated Show resolved Hide resolved
Copy link
Sponsor Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good, a few suggestions to make the docs clearer

docs/source/recipes/how-to-restrict-blocks.md Outdated Show resolved Hide resolved
docs/source/recipes/how-to-restrict-blocks.md Outdated Show resolved Hide resolved
docs/source/recipes/how-to-restrict-blocks.md Outdated Show resolved Hide resolved
Co-authored-by: David Glick <david@glicksoftware.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@sneridagh sneridagh merged commit cb39075 into main Dec 13, 2023
52 checks passed
@sneridagh sneridagh deleted the improveRestrictedBlocksFunction branch December 13, 2023 08:29
sneridagh added a commit that referenced this pull request Dec 13, 2023
…ontentType` (#5517)

Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: David Glick <david@glicksoftware.com>
sneridagh added a commit that referenced this pull request Dec 13, 2023
sneridagh added a commit that referenced this pull request Dec 13, 2023
pranayjoshi pushed a commit to pranayjoshi/volto that referenced this pull request Dec 20, 2023
…ontentType` (plone#5517)

Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: David Glick <david@glicksoftware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants