Update webpack config #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodfersou
force-pushed
the
update-webpack-config
branch
4 times, most recently
from
0a77579
to
97d86a3
Compare
rodfersou
force-pushed
the
update-webpack-config
branch
2 times, most recently
from
a42d145
to
8f42904
Compare
hvelarde
requested changes
Oct 9, 2018
| @@ -3,30 +3,12 @@ | |||
| from plone import api | |||
|
|
|||
|
|
|||
| SWIPER_CSS = '//cdnjs.cloudflare.com/ajax/libs/Swiper/4.1.6/css/swiper.min.css' | |||
There was a problem hiding this comment.
you must not mess around older upgrade steps.
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0"?> | |||
| <object name="Agenda" meta_type="Dexterity FTI" | |||
| xmlns:i18n="http://xml.zope.org/namespaces/i18n" | |||
There was a problem hiding this comment.
you're not translating anything; you can safely remove xmlns:i18n and i18n:domain.
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0"?> | |||
| <object name="AgendaDiaria" meta_type="Dexterity FTI" | |||
| xmlns:i18n="http://xml.zope.org/namespaces/i18n" | |||
There was a problem hiding this comment.
you're not translating anything; you can safely remove xmlns:i18n and i18n:domain.
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0"?> | |||
| <object name="Compromisso" meta_type="Dexterity FTI" | |||
| xmlns:i18n="http://xml.zope.org/namespaces/i18n" | |||
There was a problem hiding this comment.
you're not translating anything; you can safely remove xmlns:i18n and i18n:domain.
rodfersou
force-pushed
the
update-webpack-config
branch
from
2e498fd
to
7b483cf
Compare
hvelarde
force-pushed
the
update-webpack-config
branch
from
7b483cf
to
43837f5
Compare
hvelarde
approved these changes
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.