Plone app contenttypes 1 1 1 #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iniciando a troca de nomes das views como definido em https://github.com/plone/plone.app.contenttypes/blob/1.1.1/plone/app/contenttypes/upgrades.py#L134
Evita o erro
plone.app.contenttypes-1.1.1-py2.7.egg/plone/app/contenttypes/migration/dxmigration.py", line 74, in migrate_schema_fields
self.new.attendees = tuple(self.old.attendees.splitlines())
AttributeError: 'NoneType' object has no attribute 'splitlines'
ao rodar o upgradeStep. No caso, isso só é util se o usuário voltar a
rodar esse upgradeStep, pois para usuários que criam sites novos a
partir desse commit não terão esse problema.
Queremos evitar de pinar numa branch de portal.buildout para que no futuro, caso seja necessário remontar esse ambiente com esse commit, não dê erro na branch que terá sido excluída.
Ao atualizar para plone.app.contenttypes 1.1.1, se você tiver um evento criado pelo brasil.gov.portal sem attendees ou ter eventos criados pela interface sem preencher o campo atteendes, dá erro na migração. Por isso precisamos do patch.
Com a atualização para o plone.app.contenttypes, houve mudança no nome das views e foi necessária a sua adaptação, tanto nas templates quanto na lógica dos overrides.zcml. https://github.com/plone/plone.app.contenttypes/tree/1.1.1#user-content-differences-to-productsatcontenttypes folder_listing_view (Folders) and collection_view (Collections) -> listing_view (Folders and Collections) folder_summary_view (Folders) and summary_view (Collections) -> summary_view (Folders and Collections) folder_tabular_view (Folders) and tabular_view (Collections) -> tabular_view (Folders and Collections) folder_full_view (Folders) and all_content (Collections) -> full_view (Folders and Collections) atct_album_view (Folders) and thumbnail_view (Collections) -> album_view (Folders and Collections)
Coloca a url da branch para poder passar no travis.
test_collection_listing_view falhem. test_collection_listing_view e test_collection_summary_view estão falhando após plone.app.contenttypes >= 1.1.1 Ver: #359
idgserpro
force-pushed
the
plone_app_contenttypes_1_1_1
branch
from
b167155
to
98e8050
Compare
|
por que continua em vermelho? |
hvelarde
requested changes
Jul 7, 2017
|
@hvelarde obrigado 🍺 ! |
|
release liberado: https://pypi.python.org/pypi/brasil.gov.portal/1.2b1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Os erros são relativos à mudança de nomes das templates.
Como conversado, iremos lançar uma versão 1.1.6b1 até corrigir esses erros. Fica a seu critério se irá usar só a branch ou se efetuará um merge.