Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define tamanho de imagens para o IDG #517

Merged
merged 6 commits into from
Sep 4, 2018
Merged

Define tamanho de imagens para o IDG #517

merged 6 commits into from
Sep 4, 2018

Conversation

agnogueira
Copy link
Member

@agnogueira agnogueira commented Aug 31, 2018 •
edited by hvelarde
Loading

Define novos tamanhos de imagens para o IDG, baseado nas larguras das colunas

TODO:

  • upgrade step
  • pesquisar implicações da remoção da escala

@agnogueira
Copy link
Member Author

@rodfersou acho que precisamos de um upgrade step aqui

@rodfersou rodfersou force-pushed the image-sizes branch 2 times, most recently from a2a487f to a3ae4a5 Compare September 3, 2018 13:24
hvelarde
hvelarde requested changes Sep 3, 2018
View reviewed changes
Copy link
Member

@hvelarde hvelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

falta rebase, consertar o upgrade step, os testes e pesquisar as implicações da remoção das escalas.

@hvelarde hvelarde added 2.x and removed help wanted labels Sep 3, 2018
@rodfersou
Copy link
Member

rodfersou commented Sep 3, 2018 •
edited
Loading

@hvelarde rebase feito, upgrade step consertado

hvelarde
hvelarde requested changes Sep 3, 2018
View reviewed changes
Copy link
Member

@hvelarde hvelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o release 2.0b1 foi feito já; precisa consertar a entrada no changelog e o upgrade step; precisa também definir o que será feito com as escalas do IDG v1.

@rodfersou
Copy link
Member

@hvelarde as escalas do IDG 1.x foram revisadas em uma etapa anterior

@rodfersou
Copy link
Member

não temos nenuma referencia no código para a escala de capa que foi removida.

@agnogueira
Copy link
Member Author

agnogueira commented Sep 3, 2018 •
edited
Loading

O IDG 1 não possuía escalas, usava as escalas padrão do Plone.
Temos mais essas duas escalas aqui que não sei do que se trata:
galeria_de_album_thumb 238:133
galeria_de_foto_view 1150:650

Sabe do que se trata @rodfersou ?

A ideia aqui é criar algumas escalas genéricas para que os editores parem de criar escalas customizadas sem necessidade

@rodfersou
Copy link
Member

@agnogueira essas esclas são da view de albuns
https://github.com/plonegovbr/brasil.gov.portal/blob/master/src/brasil/gov/portal/browser/album/albuns.py#L250
https://github.com/plonegovbr/brasil.gov.portal/blob/master/src/brasil/gov/portal/browser/album/albuns.py#L276
https://github.com/plonegovbr/brasil.gov.portal/blob/master/src/brasil/gov/portal/browser/album/albuns.py#L281

Também tem o tile de albuns:
https://github.com/plonegovbr/brasil.gov.tiles/blob/master/src/brasil/gov/tiles/tiles/albuns.py#L129
https://github.com/plonegovbr/brasil.gov.tiles/blob/master/src/brasil/gov/tiles/tiles/albuns.py#L148

Podemos substituir as escalas por uma das definidas agora, somente precisamos definir qual será a nova escala ao remover essas antigas

@agnogueira
Copy link
Member Author

Sugiro tratarmos as remoções dos demais itens em um PR a parte

@rodfersou
Copy link
Member

Perguntado no forum o que acontece quando remove escalas https://community.plone.org/t/what-happen-when-remove-a-image-scale/7157

hvelarde
hvelarde requested changes Sep 3, 2018
View reviewed changes
src/brasil/gov/portal/tests/test_upgrades.py Outdated
@@ -214,7 +214,7 @@ def test_profile_version(self):

def test_registered_steps(self):
steps = len(self.setup.listUpgrades(self.profile_id)[0])
self.assertEqual(steps, 8)
self.assertEqual(steps, 9)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isso está registrado na versão do profile errado.

src/brasil/gov/portal/tests/test_upgrades.py Outdated
allowed_sizes = set(settings.allowed_sizes)
allowed_sizes |= frozenset([u'capa 230:230'])
allowed_sizes -= frozenset([
u'Imagem-Full: 1150:1150',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

por favor cria uma constante com esses valores para evitar repetir isso ai.

src/brasil/gov/portal/profiles/default/propertiestool.xml Outdated
@@ -41,9 +41,15 @@
</object>
<object name="imaging_properties" meta_type="Plone Property Sheet">
<property name="allowed_sizes" type="lines" purge="False">
<element value="capa 230:230"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinha entendido que não íamos remover nenhuma escala.

hvelarde
hvelarde requested changes Sep 3, 2018
View reviewed changes
src/brasil/gov/portal/upgrades/v10902/__init__.py Outdated


SCALES_TO_ADD = [
u'imagem-full: 1150:1150',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

os nomes das escalas estão errados.

@hvelarde hvelarde merged commit 50fd090 into master Sep 4, 2018
@hvelarde hvelarde deleted the image-sizes branch September 4, 2018 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodfersou rodfersou rodfersou approved these changes

@hvelarde hvelarde hvelarde approved these changes

Assignees
No one assigned
Labels
2.x in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@agnogueira @rodfersou @hvelarde