Added more improvements #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
macagua
commented
Jun 8, 2015
macagua
commented
- Updated package documentarion
- Added i18n support
- Added Spanish translation
|
@hvelarde What is wrong with the plone 5 travis-ci task?, It can not pass the build task :( I would like that it be possible to merge this improvements :) 👍 |
| @@ -4,4 +4,19 @@ Changelog | |||
| 1.0a1 (unreleased) | |||
| ------------------ | |||
|
|
|||
| - Fixed errors for code analysis test of this package | |||
There was a problem hiding this comment.
@macagua please do not clutter the changelog; add only stuff useful to integrators and developers; IMO this is not useful
|
@macagua tests must pass first and you have to contact @jeanferri for a merge of this |
|
@jeanferri please can check this build on travis https://travis-ci.org/plonegovbr/collective.opendata/jobs/70648696 It build job said "No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself. The build has been terminated" |
jeanferri
added a commit
that referenced
this pull request
Jul 31, 2015
Added more improvements merging @macagua pull request.
|
@jeanferri thanks very you!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.