Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeful workflow #1

Merged
merged 3 commits into from
May 12, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/ploneintranet/workspace/profiles/default/metadata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
<version>0001</version>
<dependencies>
<dependency>profile-collective.workspace:default</dependency>
<dependency>profile-Products.CMFPlacefulWorkflow:base</dependency>
</dependencies>
</metadata>
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<?xml version="1.0"?>
<object name="portal_placeful_workflow" meta_type="Placeful Workflow Tool">
<object name="ploneintranet_policy" meta_type="WorkflowPolicy"/>
</object>
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<?xml version="1.0"?>
<object name="ploneintranet_policy" meta_type="WorkflowPolicy">
<property name="title">Plone Intranet Policy</property>
<bindings>
<default>
<bound-workflow workflow_id="ploneintranet_workflow"/>
</default>
<type default_chain="true" type_id="Collection"/>
<type default_chain="true" type_id="Discussion Item"/>
<type default_chain="true" type_id="Document"/>
<type default_chain="true" type_id="Event"/>
<type default_chain="true" type_id="Folder"/>
<type default_chain="true" type_id="Link"/>
<type default_chain="true" type_id="News Item"/>
<type default_chain="true" type_id="TempFolder"/>
<type default_chain="true" type_id="Topic"/>
</bindings>
</object>
3 changes: 0 additions & 3 deletions src/ploneintranet/workspace/profiles/default/workflows.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@
<object name="ploneintranet_workflow" meta_type="Workflow" />

<bindings>
<default>
<bound-workflow workflow_id="ploneintranet_workflow" />
</default>
<type type_id="ploneintranet.workspace.workspacefolder">
<bound-workflow workflow_id="ploneintranet_workspace_workflow" />
</type>
Expand Down
11 changes: 11 additions & 0 deletions src/ploneintranet/workspace/subscribers.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
from collective.workspace.interfaces import IWorkspace
from Products.CMFPlacefulWorkflow.PlacefulWorkflowTool \
import WorkflowPolicyConfig_id


def workspace_added(ob, event):
Expand All @@ -8,3 +10,12 @@ def workspace_added(ob, event):
user=creator,
groups=set(['Admins']),
)

# Configure our placeful workflow
cmfpw = 'CMFPlacefulWorkflow'
ob.manage_addProduct[cmfpw].manage_addWorkflowPolicyConfig()

# Set the policy for the config
pc = getattr(ob, WorkflowPolicyConfig_id)
pc.setPolicyIn('')
pc.setPolicyBelow('ploneintranet_policy')
9 changes: 9 additions & 0 deletions src/ploneintranet/workspace/testing.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,21 @@ def setUpZope(self, app, configurationContext):
context=configurationContext
)

import Products.CMFPlacefulWorkflow
xmlconfig.file(
'configure.zcml',
Products.CMFPlacefulWorkflow,
context=configurationContext
)

# Install products that use an old-style initialize() function
z2.installProduct(app, 'collective.workspace')
z2.installProduct(app, 'Products.CMFPlacefulWorkflow')

def tearDownZope(self, app):
# Uninstall products installed above
z2.uninstallProduct(app, 'collective.workspace')
z2.uninstallProduct(app, 'Products.CMFPlacefulWorkflow')

def setUpPloneSite(self, portal):
applyProfile(portal, 'ploneintranet.workspace:default')
Expand Down
36 changes: 33 additions & 3 deletions src/ploneintranet/workspace/tests/test_content_workflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,43 @@ class TestWorkflow(BaseTestCase):

def test_default_workflow(self):
"""
the ploneintranet workflow should be set as the default workflow
the ploneintranet workflow should be listed as a workflow
"""
wftool = api.portal.get_tool('portal_workflow')
self.assertIn('ploneintranet_workflow',
wftool.listWorkflows())
self.assertIn('ploneintranet_workflow',
wftool.getDefaultChain())
# But no default workflow should be set
self.assertFalse(wftool.getDefaultChain())

def test_placeful_workflow(self):
"""
The ploneintranet workflowshould be applied automatically to content
in the workspace
"""
self.login_as_portal_owner()
wftool = api.portal.get_tool('portal_workflow')

# Check that a document has the default workflow
document = api.content.create(
self.portal,
'Document',
'document-portal'
)
self.assertFalse(wftool.getWorkflowsFor(document))

# A document in the workspace should have the workspace workflow
workspace_folder = api.content.create(
self.portal,
'ploneintranet.workspace.workspacefolder',
'example-workspace')

document_workspace = api.content.create(
workspace_folder,
'Document',
'document-workspace'
)
self.assertEqual('ploneintranet_workflow',
wftool.getWorkflowsFor(document_workspace)[0].id)

def test_draft_state(self):
"""
Expand Down