Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace container #43

Merged
merged 7 commits into from
Jan 9, 2015
Merged

Workspace container #43

merged 7 commits into from
Jan 9, 2015

Conversation

wengole
Copy link
Contributor

@wengole wengole commented Jan 9, 2015

Added a WorkspaceContainer content type addable only at Site root and only containing Workspaces

Ben Cole added 4 commits January 8, 2015 16:48
@@ -1,4 +1,5 @@
<?xml version="1.0"?>
<object name="portal_types" meta_type="Plone Types Tool">
<object name="ploneintranet.workspace.workspacefolder" meta_type="Dexterity FTI" />
<object name="WorkspaceContainer" meta_type="Dexterity FTI" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dexterity convention is to use the package name to make sure the type name is unique e.g. ploneintranet.workspace.workspacecontainer

@mattss
Copy link
Member

mattss commented Jan 9, 2015

A quick test to check that this is addable in the correct places would be ace.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling c43a8b4 on workspace-container into f3edb74 on master.

@wengole
Copy link
Contributor Author

wengole commented Jan 9, 2015

@mattss Happy now?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) when pulling 7988d43 on workspace-container into f3edb74 on master.

@mattss
Copy link
Member

mattss commented Jan 9, 2015

Love it.

mattss added a commit that referenced this pull request Jan 9, 2015
@mattss mattss merged commit 10f416f into master Jan 9, 2015
@jcbrand jcbrand deleted the workspace-container branch March 12, 2015 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants