-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide completions only within a SQL context #111
Provide completions only within a SQL context #111
Conversation
Specifically, offer completions if the cell begins with %%sql or we're to the right of %sql on this line. Note that this will have some false positives (if there's a string that contains '%sql'), but this should work in 99% of the cases.
hi @rschroll, thanks so much for contributing to this! this is still marked as a draft, let me know once it's ready for review! |
Two things perhaps blocking review:
|
@neelasha23 please test this to ensure it works
yep, we do the same (review until tests pass) but if contributors run into issues getting them to pass we also help!
yes, please create a new version and add an item for the changes |
I haven't been able to build this locally (and I'm facing similar issue with the
I have added manually as well by running
I have run |
thanks @rschroll, making a release now! |
Describe your changes
If we're in a SQL magic cell, or to the right of a line magic, provide SQL completions. Otherwise, don't.
Issue number
Closes #6
Checklist before requesting a review
pkgmt format