-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify --save-profiling-data to accept File Path(Ploomber Engine CLI) #78
Modify --save-profiling-data to accept File Path(Ploomber Engine CLI) #78
Conversation
tests/test_cli.py
Outdated
ValueError, | ||
), | ||
( | ||
float(123.0), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im confused about these and the values below. we're testing a CLI, so all the inputs must be serialized to strings. how come we're passing floats, dictionaries and tuples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the jupyter user might execute something like this:
_ = execute_notebook(
"notebook.ipynb", "output.ipynb", profile_memory=True, save_profiling_data=float(123.0))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If execute execute_notebook directly, it's possible we pass non-string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I understand. but this is testing the CLI. either this is a problem with runner.invoke
or the values are being serialized to strings anyway.
i think it's best to parameterized this test over different strings then. because the other values are not representative of a real CLI use case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got what you means, and this test case is to test on running on CLI
Remove other datatypes in 85b0110
But LMK if you want me to test other string
Hey! this is great, is there a planned pypi release date for |
I forgot to make the release, just did it! it ended up being 0.0.30 because there was some issue with the package's metadata (0.0.29 failed to upload to PyPI) |
Describe your changes
Now
save_profiling_data
can take Path string, also the existing bool usage will be supported as well.Changes:
save_profiling_data
option to accept PathIssue number
Closes #65
Checklist before requesting a review
pkgmt format
馃摎 Documentation preview 馃摎: https://ploomber-engine--78.org.readthedocs.build/en/78/