flake8

ploomber · Jan 15, 2022 · e888dbd · e888dbd
1 parent 2dadba0
commit e888dbd
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 27 deletions.
diff --git a/src/ploomber/scaffold/scaffoldloader.py b/src/ploomber/scaffold/scaffoldloader.py
@@ -4,11 +4,6 @@
 import jupytext
 from jinja2 import Environment, PackageLoader, StrictUndefined
 
-try:
-    import importlib.resources as resources
-except ImportError:
-    import importlib_resources as resources
-
 from ploomber import tasks
 from ploomber.util.dotted_path import (locate_dotted_path,
                                        create_intermediate_modules)
@@ -18,16 +13,14 @@ class ScaffoldLoader:
     """Scaffold task files
     """
 
-    def __init__(self, directory='ploomber_add', project_name=None):
+    def __init__(self):
         self.env = Environment(loader=PackageLoader(
-            'ploomber', str(Path('resources', directory))),
+            'ploomber', str(Path('resources', 'ploomber_add'))),
                                variable_start_string='[[',
                                variable_end_string=']]',
                                block_start_string='[%',
                                block_end_string='%]',
                                undefined=StrictUndefined)
-        self.directory = directory
-        self.project_name = project_name
 
     def get_template(self, name):
         return self.env.get_template(name)
@@ -52,11 +45,6 @@ def render(self, name, params):
 
         return out
 
-    def copy(self, name):
-        module = '.'.join(['ploomber', 'resources', self.directory])
-        content = resources.read_text(module, name)
-        Path(self.project_name, name).write_text(content)
-
     def create(self, source, params, class_):
         if class_ is tasks.PythonCallable:
             source_parts = source.split('.')

diff --git a/tests/test_scaffold.py b/tests/test_scaffold.py
@@ -8,6 +8,18 @@
 from ploomber import scaffold
 from ploomber.spec import DAGSpec
 
+template = """
+meta:
+    extract_product: {{extract_product}}
+    extract_upstream: {{extract_upstream}}
+
+tasks:
+    - source: {{name}}
+      {% if not extract_product %}
+      product: nb.ipynb
+      {% endif %}
+"""
+
 
 @pytest.mark.parametrize('name', [
     'task.py',
@@ -31,19 +43,9 @@ def test_renders_valid_script(name, extract_product, extract_upstream,
         Path(name).write_text(out)
 
         Path('pipeline.yaml').write_text(
-            Template("""
-meta:
-    extract_product: {{extract_product}}
-    extract_upstream: {{extract_upstream}}
-
-tasks:
-    - source: {{name}}
-      {% if not extract_product %}
-      product: nb.ipynb
-      {% endif %}
-""").render(name=name,
-            extract_product=extract_product,
-            extract_upstream=extract_upstream))
+            Template(template).render(name=name,
+                                      extract_product=extract_product,
+                                      extract_upstream=extract_upstream))
 
         DAGSpec('pipeline.yaml').to_dag().build()