Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pipeline plot #393

Closed
3 tasks done
edublancas opened this issue Oct 21, 2021 · 4 comments
Closed
3 tasks done

Improve pipeline plot #393

edublancas opened this issue Oct 21, 2021 · 4 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@edublancas
Copy link
Contributor

edublancas commented Oct 21, 2021

The output plot is pretty boring:

index

We're using pygraphviz to generate it and it has lots of customization options to make it better.

Here's the code that generates the plot:

def plot(self, output='embed'):

def _to_graph(self, only_current_dag=False, return_graphviz=False):

The fix involves checking the options we have in https://graphviz.org/ to make the plot prettier

To get started, you can clone one example and generate one plot: https://docs.ploomber.io/en/latest/user-guide/templates.html

one option we should have is to only show task names (hide products)

  • option to hide products
  • document option to hide products in the .rst docs
  • improve the plot style (colors, font size, etc)
@seakyith
Copy link

Can I work on this?

@edublancas
Copy link
Contributor Author

Yes! I'd really appreciate it! Feel free to reach out to us on Slack if you have questions. And please show your support with a star :)

Check out our contributing guide to get started.

@idomic
Copy link
Contributor

idomic commented Dec 10, 2021

@seakyith any updates there?
In a few days this will be reassigned.

@idomic
Copy link
Contributor

idomic commented Dec 10, 2021

@fferegrino wanna take a look?

@edublancas edublancas self-assigned this Mar 11, 2022
edublancas added a commit that referenced this issue Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants