-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to customise names of grid tasks. #647
Comments
Thanks for your feedback! Any suggestions on how this could look like? I'm thinking of having a - source: example_task.py
name: example-task
product:
data: output/output_dataframe.csv
grid:
input_dataframe: ['birds.csv', 'fish.csv', 'flowers.csv']
product_suffix: '_{{input_dataframe}}' Then, the outputs would be 'output/output_dataframe_birds.csv', etc. |
Yes! Something like that would be great. I forgot this in the original issue description, but I think the suffix also should be (optionally) added to the task name. So that the name can be the same as the products. So maybe task_suffix or task_name_suffix would be better. And I think the suffix field should be able to take a separate list like: Edit: Perhaps a task_name_prefix field could be added as well. |
I like the product_suffix as well. Would be nice to apply to task_suffix as well. That way if you had something like:
you could do, product_suffix: '-{{param1}}-{{param2}}' |
Hi all, I started working on this. Bouncing off an idea. To have a more flexible naming logic, I was thinking something like this: - source: example_task.py
name: example-task
product:
data: output/[[input_dataframe]]
grid:
input_dataframe: ['birds.csv', 'fish.csv', 'flowers.csv'] This would output: Note that this would use a special Thoughts? |
Yes, definitely would be helpful that you could have it anywhere in the product path, whether it was a directory name or part of the file name. product: so could be a prefix, suffix, directory name, etc. and of course, would need to be able to use more than one of them at once. product: |
awesome! implementation is almost ready, this will be part of our next release! |
On further thought, it would be nice to be able to use the [[param]] anywhere in the task definition (source, name, product, etc.) that way, you can also have more meaningful task names rather than the current number suffixes. |
Thanks for the feedback. I created #698 to track this. I see the use case for the task name. But what would it be a use case for |
When running tasks in a grid, a number is appended at the end of the tasks product names. For example, the following pipeline.yaml file:
would result in 3 products: output_dataframe-1.csv, output_dataframe-2.csv and output_dataframe-3.csv.
I would like to have an option to replace -1, -2 and -3 in the filenames with for example -birds, -fish and -flowers.
The text was updated successfully, but these errors were encountered: