Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click version mismatch #719

Closed
idomic opened this issue Apr 18, 2022 · 1 comment
Closed

Click version mismatch #719

idomic opened this issue Apr 18, 2022 · 1 comment
Assignees

Comments

@idomic
Copy link
Contributor

idomic commented Apr 18, 2022

We've seen some mismatch between the ploomber version and the one sagemaker has with Spacy, Spacy wouldn't get imported because of typer that wouldn't get imported because a dependency on click:

----> 1 import typer
~/anaconda3/envs/mxnet_latest_p37/lib/python3.7/site-packages/typer/init.py in
10 from click.termui import echo_via_pager as echo_via_pager
11 from click.termui import edit as edit
---> 12 from click.termui import get_terminal_size as get_terminal_size
13 from click.termui import getchar as getchar
14 from click.termui import launch as launch
ImportError: cannot import name 'get_terminal_size' from 'click.termui' (/home/ec2-user/anaconda3/envs/mxnet_latest_p37/lib/python3.7/site-packages/click/termui.py)

@edublancas
Copy link
Contributor

So this is related to #707

Based on what we've seen this is what I think it's happening:

  1. User installs a bunch of packages, and some of them are not compatible with recent versions of click
  2. Using an old version of click breaks ploomber because the package_name argument was added recently
  3. They end up with broken environments: they either break some other libraries or ploomber

The solution is to make Ploomber compatible with as many versions as we can, looks like by removing the call to package_name things will work. It's fairly easy to fix, I'll take this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants