Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated banner #1156

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Updated banner #1156

merged 2 commits into from
Feb 19, 2024

Conversation

neelasha23
Copy link
Contributor

@neelasha23 neelasha23 commented Feb 9, 2024

Describe your changes

Issue number

Closes ploomber/doc#76

Checklist before requesting a review


馃摎 Documentation preview 馃摎: https://ploomber--1156.org.readthedocs.build/en/1156/

@neelasha23
Copy link
Contributor Author

neelasha23 commented Feb 9, 2024

The announcement feature is available only in the pydata-sphinx-theme and sphinx-book-theme : https://stackoverflow.com/a/75563601

Updating the theme is causing the build to fail with more errors. I have just added an rst_prolog. Please check if it looks ok @edublancas

@neelasha23 neelasha23 marked this pull request as ready for review February 9, 2024 16:28
@edublancas
Copy link
Contributor

It'd be better to add the banner at the top of the page. above the navigation bar.

image

I remember there is an HTML file that defines the navigation bar, you can edit it and add the banner there

@neelasha23
Copy link
Contributor Author

I tried adding a div in macros.html and it gets displays below the navigation bar. Also trying to add a content block in layout.html but I keep getting errors. Still looking into it.

sphinx version

theme

theme

install

install

install

theme

theme

prolog

prolog

sphinx versio

sphinx versio

html

new theme

new theme

new theme

new theme

normal link

normal link

normal link

normal link

normal link

normal link

normal link

normal link

navbar

macro

macro

macro

macro

macro

macro

macro

macro

macro

template

template

template

template

template

announcement

announcement

announcement

announcement

div

div

div

div

revert changes

added link

added link
@neelasha23
Copy link
Contributor Author

Addressed the comment. Please review @edublancas

Copy link
Contributor

@edublancas edublancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please center the text and make the font a little smaller (same size as the text in the nav bar):

image

also, a gray space appears in mobiles:

image

styling

padding

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

style

height

height

height

height

height

height

height

height

height

height

height

height
@neelasha23
Copy link
Contributor Author

Addressed the comments. I also noticed that the announcement bar and the navigation bar were moving when scrolling the page. Have also fixed that. The space in mobile also seems to be fixed:

Screenshot_20240219-152558_Samsung Internet

@edublancas

@edublancas edublancas merged commit 6eed5e2 into master Feb 19, 2024
9 of 12 checks passed
@edublancas edublancas deleted the banner branch February 19, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update ploomber cloud banner
2 participants