Version update - New branch #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this ready for review? |
Closed
edublancas
requested changes
Feb 8, 2022
| monkeypatch=monkeypatch, | ||
| last_check='2022-01-20 10:51:41.082376') # version='0.14.8', | ||
|
|
||
| # Test no warning when same version encountered |
There was a problem hiding this comment.
wait, what is this testing?
There was a problem hiding this comment.
I wanted to test no echo was printed when it's the same version, for some reason the patch I tried on the ploomber.version didn't work, not sure why.
edublancas
reviewed
Feb 9, 2022
|
check errors, the build is failing |
|
tests pass. is this ready for review? |
|
Give me today to run some more tests on it :)
…On Mon, Feb 14, 2022 at 12:00 PM Eduardo Blancas ***@***.***> wrote:
tests pass. is this ready for review?
—
Reply to this email directly, view it on GitHub
<#558 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACYPJONO23NS3VLCEOZTIJLU3EYKZANCNFSM5NYETLSQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
sure! I quickly skimmed through the code: can you add a test for the timeout? I see the |
… on function runtime
|
@edublancas ready for review, I've decoupled the files and added the timeouts check |
edublancas
requested changes
Feb 17, 2022
edublancas
approved these changes
Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.