Refactors config files #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you review this @idomic ? |
idomic
reviewed
Apr 23, 2022
src/ploomber/config.py
Outdated
|
|
||
|
|
||
| class Config(abc.ABC): | ||
| """And abstract class to create configuration files (stored as YAML) |
idomic
reviewed
Apr 23, 2022
| return Path(check_dir_exist(CONF_DIR), DEFAULT_USER_CONF) | ||
|
|
||
|
|
||
| class Internal(Config): |
There was a problem hiding this comment.
Maybe call it ploomber settings?
There was a problem hiding this comment.
I want to be more explicit that these are for internal use and others are for users.
idomic
requested changes
Apr 23, 2022
| assert telemetry.check_first_time_usage() | ||
| assert not telemetry.check_first_time_usage() | ||
|
|
There was a problem hiding this comment.
How does this pass, now that we don't set the conf?
There was a problem hiding this comment.
I added a one-off flag to the config to replicate this functionality
There was a problem hiding this comment.
Cool just make sure it works via the dashboard
idomic
approved these changes
Apr 25, 2022
neelasha23
pushed a commit
to neelasha23/ploomber
that referenced
this pull request
May 22, 2022
* deletes empty function * reorders imports * functions to return paths to config files * simplifying config file read * adding Internal and Storage classes * simplifying writes * renaming * adds Config * improvements to Config * refactors telemetry and cloud to use new Config * documents config * improves warning messages * flake8 * validating config types * fixes typo * flake8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored the logic to store and retrieve the data from the config files. This is a pre-requisite to start working on the improved onboarding workflow where we have a "tutorial" to point to the user what do to next since we need to add a few extra flags to the config files to track the state.
The tests remain unchanged (I only modified a few and deleted some that are outdated)