Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New email, merged mainline #729

Merged
merged 3 commits into from Apr 27, 2022
Merged

New email, merged mainline #729

merged 3 commits into from Apr 27, 2022

Conversation

idomic
Copy link
Contributor

@idomic idomic commented Apr 26, 2022

No description provided.

@idomic idomic changed the title Initial commit from mainline New email, merged mainline Apr 26, 2022
Fixing tests

Fixing tests

Fixing tests

Fixing tests
@edublancas
Copy link
Contributor

I ran "ploomber examples" a few times, saw the email prompt and typed enter (did not enter email). Every time, I was asked for an email. But this shouldn't happen (we should only ask once). We can use the new config to set a one-time flag to do this:

def check_first_time_usage():

I noticed that after submitting an email, the "ploomber examples" have a slight delay. Is it hitting the lambda again?

Finally, I think there should be a newline character to separate the regular "ploomber examples" output from the email signup, looks too cluttered

To run these examples in free, hosted environment, see instructions at: https://github.com/ploomber/projects
To download: ploomber examples -n name -o path
Example: ploomber examples -n templates/ml-basic -o ml
Our users enjoy updates, support and unique content through email, please add your email, if you'd like to register (type email): 

@idomic
Copy link
Contributor Author

idomic commented Apr 27, 2022

I ran "ploomber examples" a few times, saw the email prompt and typed enter (did not enter email). Every time, I was asked for an email. But this shouldn't happen (we should only ask once). We can use the new config to set a one-time flag to do this:

def check_first_time_usage():

I noticed that after submitting an email, the "ploomber examples" have a slight delay. Is it hitting the lambda again?

Finally, I think there should be a newline character to separate the regular "ploomber examples" output from the email signup, looks too cluttered

To run these examples in free, hosted environment, see instructions at: https://github.com/ploomber/projects
To download: ploomber examples -n name -o path
Example: ploomber examples -n templates/ml-basic -o ml
Our users enjoy updates, support and unique content through email, please add your email, if you'd like to register (type email): 

Fixed, there was a missing test for empty emails. There's already a flag used called settings.user_email

@idomic idomic merged commit 74eb638 into master Apr 27, 2022
@edublancas edublancas deleted the email_new branch April 27, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants