Added tests for 3.10 #817
Merged
Added tests for 3.10 #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests CI check on python 3.10 for pygraphviz install Trying to fix R issus
Added tests CI check on python 3.10 for pygraphviz install Trying to fix R issus
|
is this ready for review? I see one windows test failing but that one fails intermittently (haven't been able to fix it) |
|
I see in windows 3.10 there are a few that's failing and probably need the skip flag. |
|
ah yeah. I see them. it's because they need pygraphviz. I think let's only skip them when running on Python 3.10 and windows (so both conditions) |
|
pygraphviz had issues with 3.10 so it's disabled on linux and macos as
well, so the current condition is <3.10, I've added those skips lets see if
it's passing now.
…On Tue, May 31, 2022 at 8:45 AM Eduardo Blancas ***@***.***> wrote:
ah yeah. I see them. it's because they need pygraphviz. I think let's only
skip them when running on Python 3.10 and windows (so both conditions)
—
Reply to this email directly, view it on GitHub
<#817 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACYPJOMR2FRZIQBENMOMC7DVMYCXXANCNFSM5XEFXXVQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
got it! |
|
the CI is failing but I think it's because of the intermittent issue. lmk when it's ready for review |
|
I think it's ready there are some windows 3.10 tests that are failing even with the skip, not sure if thats the intermittent ones. Also you might see more files since I rebased on the master |
|
Why do we need an extra branch here? |
|
i wanted to trigger an extra run to see the CI, will merge shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.