Skip to content

Commit

Permalink
Merge a58f040 into 6a6599f
Browse files Browse the repository at this point in the history
  • Loading branch information
edublancas committed Sep 6, 2023
2 parents 6a6599f + a58f040 commit 4265727
Show file tree
Hide file tree
Showing 14 changed files with 5 additions and 7 deletions.
6 changes: 2 additions & 4 deletions doc/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,8 @@
html_theme_options = {
"analytics": {"google_analytics_id": "G-3KL9PSJBZZ"},
"announcement": (
"To launch a tutorial, click on the 🚀 button "
"below! Join us on "
"<a href='https://ploomber.io/community/'>Slack!</a>"
"Host Voilà and Streamlit apps for free with "
"<a href='https://www.platform.ploomber.io/register/'>Ploomber Cloud!</a>"
),
"search_bar_text": "Search this book...",
"launch_buttons": {
Expand All @@ -66,7 +65,6 @@
"repository_branch": repository_branch,
"extra_footer": "",
"home_page_in_toc": True,
"announcement": "To launch any tutorial in JupyterLab, click on the 🚀 button below!",
"use_repository_button": True,
"use_edit_page_button": False,
"use_issues_button": True,
Expand Down
2 changes: 1 addition & 1 deletion src/sklearn_evaluation/plot/roc.py
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ def __init__(self, fpr, tpr, label=None):
if fpr is None or tpr is None:
raise TypeError("fpr and tpr must be defined.")

if type(fpr) != type(tpr):
if type(fpr) is not type(tpr):
raise TypeError(
"fpr and tpr must be the same type. "
f"Recevied: fpr {type(fpr)} != tpr {type(tpr)}"
Expand Down
4 changes: 2 additions & 2 deletions src/sklearn_evaluation/tracker.py
Original file line number Diff line number Diff line change
Expand Up @@ -411,9 +411,9 @@ def upsert_append(self, uuid, parameters):
# with values from parameters
for key in keys:
if key in existing and key in parameters:
if type(existing[key]) != list:
if not isinstance(existing[key], list):
existing[key] = [existing[key]]
if type(parameters[key]) != list:
if not isinstance(parameters[key], list):
existing[key].append(parameters[key])
else:
existing[key].extend(parameters[key])
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/baseline_images/test_clustering/silhouette_plot_cosine.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/baseline_images/test_clustering/silhouette_plot_spectral.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 4265727

Please sign in to comment.