ignoring standard error in notebook introspector

src/sklearn_evaluation/nb/NotebookIntrospector.py

@@ -56,9 +56,17 @@ def _process_output(output):
                                   'implemented'.format(out_type))
 
 
-def _filter_and_process_outputs(outputs):
+def _allowed_output(output):
     allowed = {'stream', 'display_data', 'execute_result'}
-    outputs = [o for o in outputs if o['output_type'] in allowed]
+
+    if output['output_type'] in allowed:
+        return output.get('name') != 'stderr'
+    else:
+        return False
+
+
+def _filter_and_process_outputs(outputs):
+    outputs = [o for o in outputs if _allowed_output(o)]
     # just return the latest output if any
     return None if not outputs else _process_output(outputs[-1])
 

tests/nb/conftest.py

@@ -143,3 +143,26 @@ def nb_str():
 print('something')
 """
     return save_notebook(content, 'nb.ipynb')
+
+
+@pytest.fixture
+def nb_many_str():
+    content = """
+# + tags=["str"]
+print('a')
+print('b')
+print('c')
+"""
+    return save_notebook(content, 'nb.ipynb')
+
+
+@pytest.fixture
+def nb_stderr():
+    content = """
+import sys
+
+# + tags=["str"]
+print('this should not appear', file=sys.stderr)
+print('something')
+"""
+    return save_notebook(content, 'nb.ipynb')

tests/nb/test_NotebookIntrospector.py

@@ -79,10 +79,16 @@ def test_get_injected_parameters_multiple_lines(
     }
 
 
-def test_ignores_standard_error():
-    raise NotImplementedError
+def test_ignores_standard_error(tmp_directory, nb_stderr):
+    d = NotebookIntrospector('nb.ipynb')
+    assert d['str'] == 'something'
 
 
 def test_strips_whitespace(tmp_directory, nb_str):
     d = NotebookIntrospector('nb.ipynb')
     assert d['str'] == 'something'
+
+
+def test_many_str(tmp_directory, nb_many_str):
+    d = NotebookIntrospector('nb.ipynb')
+    assert d['str'] == 'a\nb\nc'