add cloud link (#339)

* adds cloud link * fix * lint * overriding failed images * update baseline images * fix * fix
ploomber · Sep 6, 2023 · 9b0ac2d · 9b0ac2d
1 parent 6a6599f
commit 9b0ac2d
Show file tree

Hide file tree

Showing 15 changed files with 6 additions and 8 deletions.
diff --git a/doc/conf.py b/doc/conf.py
@@ -49,9 +49,8 @@
 html_theme_options = {
     "analytics": {"google_analytics_id": "G-3KL9PSJBZZ"},
     "announcement": (
-        "To launch a tutorial, click on the 🚀 button "
-        "below! Join us on "
-        "<a href='https://ploomber.io/community/'>Slack!</a>"
+        "Host Voilà and Streamlit apps for free with "
+        "<a href='https://www.platform.ploomber.io/register/'>Ploomber Cloud!</a>"
     ),
     "search_bar_text": "Search this book...",
     "launch_buttons": {
@@ -66,7 +65,6 @@
     "repository_branch": repository_branch,
     "extra_footer": "",
     "home_page_in_toc": True,
-    "announcement": "To launch any tutorial in JupyterLab, click on the 🚀 button below!",
     "use_repository_button": True,
     "use_edit_page_button": False,
     "use_issues_button": True,

diff --git a/doc/optimization/underfitting_overfitting.md b/doc/optimization/underfitting_overfitting.md
@@ -98,7 +98,7 @@ X, y = make_classification(
     n_informative=2,
     n_repeated=2,
     n_redundant=2,
-    class_sep=0,
+    class_sep=0.0001,
     random_state=0,
 )
 ```

diff --git a/src/sklearn_evaluation/plot/roc.py b/src/sklearn_evaluation/plot/roc.py
@@ -356,7 +356,7 @@ def __init__(self, fpr, tpr, label=None):
         if fpr is None or tpr is None:
             raise TypeError("fpr and tpr must be defined.")
 
-        if type(fpr) != type(tpr):
+        if type(fpr) is not type(tpr):
             raise TypeError(
                 "fpr and tpr must be the same type. "
                 f"Recevied: fpr {type(fpr)} != tpr {type(tpr)}"

diff --git a/src/sklearn_evaluation/tracker.py b/src/sklearn_evaluation/tracker.py
@@ -411,9 +411,9 @@ def upsert_append(self, uuid, parameters):
         # with values from parameters
         for key in keys:
             if key in existing and key in parameters:
-                if type(existing[key]) != list:
+                if not isinstance(existing[key], list):
                     existing[key] = [existing[key]]
-                if type(parameters[key]) != list:
+                if not isinstance(parameters[key], list):
                     existing[key].append(parameters[key])
                 else:
                     existing[key].extend(parameters[key])

diff --git a/...seline_images/test_clustering/silhouette_analysis_from_results_cluster_five.png b/...seline_images/test_clustering/silhouette_analysis_from_results_cluster_five.png
diff --git a/...aseline_images/test_clustering/silhouette_analysis_from_results_cluster_six.png b/...aseline_images/test_clustering/silhouette_analysis_from_results_cluster_six.png
diff --git a/tests/baseline_images/test_clustering/silhouette_plot_cosine.png b/tests/baseline_images/test_clustering/silhouette_plot_cosine.png
diff --git a/tests/baseline_images/test_clustering/silhouette_plot_five_clusters.png b/tests/baseline_images/test_clustering/silhouette_plot_five_clusters.png
diff --git a/...seline_images/test_clustering/silhouette_plot_five_clusters_minibatchkmeans.png b/...seline_images/test_clustering/silhouette_plot_five_clusters_minibatchkmeans.png
diff --git a/tests/baseline_images/test_clustering/silhouette_plot_four_clusters.png b/tests/baseline_images/test_clustering/silhouette_plot_four_clusters.png
diff --git a/...seline_images/test_clustering/silhouette_plot_four_clusters_minibatchkmeans.png b/...seline_images/test_clustering/silhouette_plot_four_clusters_minibatchkmeans.png
diff --git a/tests/baseline_images/test_clustering/silhouette_plot_six_clusters.png b/tests/baseline_images/test_clustering/silhouette_plot_six_clusters.png
diff --git a/tests/baseline_images/test_clustering/silhouette_plot_spectral.png b/tests/baseline_images/test_clustering/silhouette_plot_spectral.png
diff --git a/tests/baseline_images/test_clustering/silhouette_plot_three_clusters.png b/tests/baseline_images/test_clustering/silhouette_plot_three_clusters.png
diff --git a/tests/baseline_images/test_clustering/silhouette_plot_two_clusters.png b/tests/baseline_images/test_clustering/silhouette_plot_two_clusters.png