fix: empty prompts should now bypass properly

Co-authored-by: Axel Hecht <axel@pike.org>
plopjs · Dec 9, 2021 · 1969d45 · 1969d45
1 parent 3fe7308
commit 1969d45
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/src/bypass.js b/src/bypass.js
@@ -52,7 +52,7 @@ function combineBypassData(generator, bypassArr, plopArgV) {
       process.exit(1);
     }
     namedBypassArr = promptNames.map((name) =>
-      plopArgV[name] ? plopArgV[name] : undefined
+      plopArgV[name] !== undefined ? plopArgV[name] : undefined
     );
   }
 

diff --git a/tests/examples/prompt-only/plopfile.js b/tests/examples/prompt-only/plopfile.js
@@ -6,12 +6,6 @@ export default function (plop) {
         type: "input",
         name: "name",
         message: "What is your name?",
-        validate: function (value) {
-          if (/.+/.test(value)) {
-            return true;
-          }
-          return "name is required";
-        },
       },
       {
         type: "checkbox",

diff --git a/tests/input-processing.spec.js b/tests/input-processing.spec.js
@@ -94,4 +94,13 @@ test("Should bypass prompt by name", async () => {
   expect(await findByText("What pizza toppings do you like?")).toBeTruthy();
 });
 
+test("Should allow for empty string bypassing", async () => {
+  const { queryByText, findByText } = await renderPlop(["--", "--name", `""`], {
+    cwd: resolve(__dirname, "./examples/prompt-only"),
+  });
+
+  expect(await queryByText("What is your name?")).toBeFalsy();
+  expect(await findByText("What pizza toppings do you like?")).toBeTruthy();
+});
+
 test.todo("Dynamic actions");