Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config dest path globally for wrapper #233

Merged
merged 2 commits into from
Jul 22, 2020
Merged

Config dest path globally for wrapper #233

merged 2 commits into from
Jul 22, 2020

Conversation

vinicius0026
Copy link
Contributor

Fixes #228

I have tested locally and it works.

I've added some notes to the README, feel free to improve them/suggest improvements.

Let me know your thoughts.

crutchcorn
crutchcorn approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@crutchcorn crutchcorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look great! I was going to ask about documentation additions, but they were already there! Thanks again for the addition

@crutchcorn crutchcorn merged commit 89dd05f into plopjs:master Jul 22, 2020
@vinicius0026 vinicius0026 deleted the config-destPath-globally-for-wrapper branch July 22, 2020 13:12
@renovate renovate bot mentioned this pull request Jun 6, 2021
Open
1 task
@renovate renovate bot mentioned this pull request Jun 25, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crutchcorn crutchcorn crutchcorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure destBasePath explicitly in the wrapper
2 participants
@vinicius0026 @crutchcorn