Return error code on failures on actions #300
Conversation
There was a problem hiding this comment.
One tiny change that I think I'll merge myself (just the test string), but this looks awesome, thanks so much!
Also thank you for putting up with the lack of cli-testing-library's docs. I promise I'm working on that currently
Just curious: what are your initial thoughts on cli-testing-library? Anything you liked, didn't like, thinks needs changing in the API, etc?
TBH, I don't know. I don't have a ton of expectations on js test infrastructure, I mostly go with the flow of the code base. I guess I was looking for the thing that was used least-or-not-at-all, waiting for the process to finish and then check the result. The fact that that could be done on some output matching was a bit surprising. I initially tried to do it on the result from render, but I also think I didn't try that in the way that ended up working in this patch. One use-case I have in my head is to use this for plops that have conditional prompts. Not sure if I'll end up giving that a shot, as our use is also rather convoluted UX. Might be better in our case to just separate the generators. |
Fixes #299
@crutchcorn, I tested your suggestion locally, and that did the trick. I took a stab at the test, which seems to test the right thing to me, but YYMV.