Shorthand to load all plop assets #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The links from the include section now link to the `IncludeDefinition` correctly.
Reflects the changes proposed to `node-plop` to allow all target assets to be loaded using:
```js
plop.load('./plopfiles/component.js', {}, true);
```
The `node-plop` PR can be found here: plopjs/node-plop#187
Currently the `load` function doesn't include all assets when the `includeCfg` option is set to `true`, *it doesn't load anything*! The suggested code change should bring the implementation back into line with the docs: https://github.com/plopjs/plop/blob/master/plop-load.md#interface-includedefinition
Make sure the proposed changes actually work!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
loadfunction doesn't include all assets when theincludeCfgoption is set totrue.The suggested code change should allow a shorthand to include all assets:
This is a fix for issue: #326
Suggested changes to the
plop.loaddoc here: #243