Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci_prepare.jl #104

Merged
merged 1 commit into from
May 7, 2021
Merged

Fix ci_prepare.jl #104

merged 1 commit into from
May 7, 2021

Conversation

waralex
Copy link
Collaborator

@waralex waralex commented May 7, 2021

Changed the addition of core packages from a direct link to git to the installation of the package. Also the tested code is connected via Pkg.develop instead of Pkg.add.

@waralex waralex requested a review from alexcjohnson May 7, 2021 14:11
@github-actions github-actions bot added the tests label May 7, 2021
@waralex waralex mentioned this pull request May 7, 2021
2 tasks
Copy link
Contributor

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 This looks great. I'd vote to just merge this PR, then in #102 we can merge back in from the updated dev branch.

@waralex
Copy link
Collaborator Author

waralex commented May 7, 2021

I'd vote to just merge this PR, then in #102 we can merge back in from the updated dev branch.

All right, we'll do that.

@waralex waralex merged commit 3fbfae4 into dev May 7, 2021
@etpinard etpinard deleted the dev_ci branch June 13, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants