Add support for HTTP compression using gzip #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@waralex 🚨:tada: I've added a suite of unit tests as we discussed. |
rpkyle
force-pushed
the
14-add-compression
branch
from
9204492
to
ee7b556
Compare
waralex
reviewed
Apr 27, 2020
| @@ -107,7 +135,9 @@ function make_handler(app::DashApp; debug::Bool = false) | |||
| end | |||
| end | |||
| end | |||
| if @isdefined body | |||
| return make_response(200, headers, body, with_gzip) | |||
| end | |||
There was a problem hiding this comment.
@rpkyle I suggest not using isdefined, instead it's better to define body:: Union{Nothing, String} = nothing at the beginning of the function and change the check to isnothing(body)
rpkyle
force-pushed
the
14-add-compression
branch
from
14b5f20
to
08bb621
Compare
waralex
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request proposes to add support for compressing the body of HTTP responses using
gzipwhencompress=trueand the request'sAccept-Encodingheader includesgzip. In addition, some minor refactoring is suggested to improve 🌴.To do:
compressis set onappcreation.Closes #17.