Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Julia test workflow #176

Merged
merged 5 commits into from
Jan 27, 2023
Merged

Add Julia test workflow #176

merged 5 commits into from
Jan 27, 2023

Conversation

etpinard
Copy link
Collaborator

As discussed in #175 (comment), I think it would be easier to run the Julia ] test for different Julia versions inside a Github workflow instead of inside the plotly/julia:ci docker container.

Running Julia tests inside Github workflows is fairly easy now thanks to the julia-actions organisation. This should make it much easier to maintain the list of tested Julia versions for Dash.jl. It's much easier to patch a yaml file than updating a docker image, right? 😛

I'm thinking we could also drop these lines:

- run:
name: 🔎 Unit tests
command: |
julia test/ci_prepare.jl

Pkg.test("Dash", coverage=true)

and have the CircleCI workflow be used just for the integration (percy) tests.

to run the Julia `] test`
on multiple Julia versions.
to match PlotlyBase compat
@github-actions github-actions bot added the CI label Nov 28, 2022
jl_version: ["1.3", "1.6", "1.8"]
jl_version: ["1.4", "1.6", "1.8"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing on Julia 1.3 leads to

image

We should probably update

julia = "1.3"

to match the PlotlyBase.jl compat

@etpinard
Copy link
Collaborator Author

Hmm, I'll need to figure out why the final step of the CircleCI workflow is failing

image

@mind6
Copy link
Contributor

mind6 commented Dec 3, 2022

As discussed in #175 (comment), I think it would be easier to run the Julia ] test for different Julia versions inside a Github workflow instead of inside the plotly/julia:ci docker container.

Running Julia tests inside Github workflows is fairly easy now thanks to the julia-actions organisation. This should make it much easier to maintain the list of tested Julia versions for Dash.jl. It's much easier to patch a yaml file than updating a docker image, right? 😛

I'm thinking we could also drop these lines:

- run:
name: 🔎 Unit tests
command: |
julia test/ci_prepare.jl

Pkg.test("Dash", coverage=true)

and have the CircleCI workflow be used just for the integration (percy) tests.

The github actions seem quite nice. Don't know anything about CircleCI/percy hope it works out.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 27, 2023
@etpinard
Copy link
Collaborator Author

We have passing tests 🎉 - merging!

@etpinard etpinard merged commit 754ff49 into dev Jan 27, 2023
@etpinard etpinard deleted the jl_test-worfflow branch January 27, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants