-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Julia test workflow #176
Conversation
to run the Julia `] test` on multiple Julia versions.
to match PlotlyBase compat
.github/workflows/jl_test.yml
Outdated
jl_version: ["1.3", "1.6", "1.8"] | ||
jl_version: ["1.4", "1.6", "1.8"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing on Julia 1.3 leads to
We should probably update
Line 39 in f0606e0
julia = "1.3" |
to match the PlotlyBase.jl compat
The github actions seem quite nice. Don't know anything about CircleCI/percy hope it works out. |
to match the compat of `PlotlyBase.jl` (one of our deps)
We have passing tests 🎉 - merging! |
As discussed in #175 (comment), I think it would be easier to run the Julia
] test
for different Julia versions inside a Github workflow instead of inside theplotly/julia:ci
docker container.Running Julia tests inside Github workflows is fairly easy now thanks to the julia-actions organisation. This should make it much easier to maintain the list of tested Julia versions for Dash.jl. It's much easier to patch a yaml file than updating a docker image, right? 😛
I'm thinking we could also drop these lines:
Dash.jl/.circleci/config.yml
Lines 30 to 33 in f0606e0
Dash.jl/test/ci_prepare.jl
Line 11 in f0606e0
and have the CircleCI workflow be used just for the integration (percy) tests.