Enable integration tests with Dash.jl and add server startup message #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems ok 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to add integration test support in
plotly/Dash.jl, based on work performed in plotly/dash#1239. When that PR merges intodevof theplotly/dashrepo, we'll need to modify the CircleCI configuration to use that branch instead.A simple example test is included. Future tests should follow the same general structure and be placed into
test/integration, and subdirectories may be used to help group similar tests (e.g.callbacks,devtools,clientside).The default host remains
127.0.0.1but the default port is changed to8050, which matches Dash for R and Python.A minor modification to
src/Dash.jlis also proposed which adds a basic startup message at HTTP.jl launch time: