Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle empty children for index by id #219

Closed
wants to merge 2 commits into from
Closed

handle empty children for index by id #219

wants to merge 2 commits into from

Conversation

BeastyBlacksmith
Copy link
Contributor

unfortunately I missed this case in #203

@etpinard
Copy link
Collaborator

Great.

Look like you added your commit on an outdated base branch.

Would you mind rebasing your branch off the latest dev and submitting a new PR? Thanks!

@BeastyBlacksmith
Copy link
Contributor Author

done

@etpinard
Copy link
Collaborator

etpinard commented Aug 1, 2023

Come to think of it. The Base.getindex(component::DashBase.Component, id::AbstractString) definition is type-piracy

Would you mind moving it (along with its tests) to DashBase.jl ?

@BeastyBlacksmith BeastyBlacksmith mentioned this pull request Aug 2, 2023
Merged
@BeastyBlacksmith
Copy link
Contributor Author

I moved that, tests will fail until plotly/DashBase.jl#5 is merged and released

@etpinard etpinard mentioned this pull request Aug 23, 2023
Merged
@etpinard
Copy link
Collaborator

Essentially done in #223

@etpinard etpinard closed this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BeastyBlacksmith @etpinard