Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix convert([v], v) dispatch for Julia 1.10 #231

Merged
merged 4 commits into from
Dec 28, 2023
Merged

Fix convert([v], v) dispatch for Julia 1.10 #231

merged 4 commits into from
Dec 28, 2023

Conversation

etpinard
Copy link
Collaborator

@etpinard etpinard commented Nov 6, 2023

fixes #228


This is crucial for CallbackDeps instantiation

struct CallbackDeps
output ::Vector{<:Output}
input ::Vector{<:Input}
state ::Vector{<:State}
multi_out::Bool
CallbackDeps(output, input, state, multi_out) = new(output, input, state, multi_out)
CallbackDeps(output::Output, input, state = State[]) = new(output, input, state, false)
CallbackDeps(output::Vector{<:Output}, input, state = State[]) = new(output, input, state, true)
end

I'm not sure why the Julia <=1.9 dispatch fails in Julia 1.10.

It seems that Julia 1.10 is more strict about element types during conversion to Vector.

In 1.9

image

but in 1.10

image

Any help on this topic would be much appreciated.

I'm not sure why the Julia <=1.9 dispatch fails
in Julia 1.10.

It seems that Julia 1.10 is more strict about
element type during convertion to `<:Vector`.
@github-actions github-actions bot added the CI label Nov 6, 2023
@etpinard etpinard merged commit 471b748 into dev Dec 28, 2023
11 of 13 checks passed
@etpinard etpinard deleted the adapt-for-1.10 branch December 28, 2023 17:23
@etpinard etpinard mentioned this pull request Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failing with Julia 1.10.0-beta3
1 participant