Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #27 #28

Merged
merged 2 commits into from
May 20, 2020
Merged

Fix for #27 #28

merged 2 commits into from
May 20, 2020

Conversation

waralex
Copy link
Collaborator

@waralex waralex commented May 20, 2020

@waralex waralex requested a review from rpkyle May 20, 2020 18:33
@github-actions github-actions bot added enhancement New feature or request tests labels May 20, 2020
@waralex waralex linked an issue May 20, 2020 that may be closed by this pull request
Children should never be undefined in JSON passed to dash-renderer; results in reducer "layout" error #27
Closed
rpkyle
rpkyle approved these changes May 20, 2020 •
edited
Loading
View reviewed changes
@rpkyle rpkyle self-requested a review May 20, 2020 19:47
@rpkyle
Copy link
Contributor

rpkyle commented May 20, 2020

@waralex My mistake, let's hold off and see if there's a better way to fix this in plotly/dash itself before merging.

alexcjohnson
alexcjohnson approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@waralex waralex merged commit 31847e2 into dev May 20, 2020
@rpkyle rpkyle deleted the fix_missing_children branch May 20, 2020 21:04
@rpkyle rpkyle mentioned this pull request May 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

@rpkyle rpkyle Awaiting requested review from rpkyle

Assignees
No one assigned
Labels
enhancement New feature or request tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Children should never be undefined in JSON passed to dash-renderer; results in reducer "layout" error
3 participants
@waralex @rpkyle @alexcjohnson