Skip to content

Commit

Permalink
Fixing building and publishing
Browse files Browse the repository at this point in the history
  • Loading branch information
andrefarzat committed Jan 12, 2019
1 parent ace762c commit 2b18223
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 4 deletions.
2 changes: 2 additions & 0 deletions .circleci/config.yml
Expand Up @@ -34,6 +34,8 @@ jobs:
- node_modules
key: v1-dependencies-{{ checksum "package.json" }}

- run: npm run build -- --prod

# run tests!
- run: npm run lint
- run: npm run test -- --watch=false --code-coverage
Expand Down
2 changes: 1 addition & 1 deletion bin/build
Expand Up @@ -7,7 +7,7 @@ then
exit 1;
fi

npm run build
npm run build:publish

mv ./angular-plotly.js.metadata.json dist
cp ./README.md dist
Expand Down
3 changes: 2 additions & 1 deletion package.json
Expand Up @@ -6,7 +6,8 @@
"scripts": {
"ng": "ng",
"start": "ng serve",
"build": "ng-packagr -p ng-package.json",
"build": "ng build",
"build:publish": "ng-packagr -p ng-package.json",
"lint": "ng lint",
"test": "ng test",
"postversion": "git push && git push --tags"
Expand Down
2 changes: 1 addition & 1 deletion src/app/plotly-via-cdn/plotly-via-cdn.module.ts
Expand Up @@ -11,7 +11,7 @@ import { SharedModule } from '../shared/shared.module';
exports: [PlotComponent]
})
export class PlotlyViaCDNModule {
static plotlyVersion?: string;
static plotlyVersion?: string = 'latest';

static setPlotlyVersion(version: string) {
const isOk = version === 'latest' || /^\d\.\d{1,2}\.\d{1,2}$/.test(version);
Expand Down
2 changes: 1 addition & 1 deletion src/app/shared/plotly.service.ts
Expand Up @@ -7,7 +7,7 @@ import { Plotly } from './plotly.interface';
})
export class PlotlyService {
protected static instances: Plotly.PlotlyHTMLElement[] = [];
protected static _plotly?: any;
protected static _plotly?: any = undefined;

public static setPlotly(plotly: any) {
PlotlyService._plotly = plotly;
Expand Down

0 comments on commit 2b18223

Please sign in to comment.