update to d3-sankey 0.7.1 + fix problem with large padding #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Align API Documentation with source code. * Add missing methods `size` and `link` * Remove inapplicable references to accessor functions * Provide information about `nodes` and `links` * Clarify how links can be initialized based on numeric index into `nodes` array.
…ankey into tomwanzek-api-doc-revisited
* [Documentation] Clarify wording of convenience method for initializing links. Array of nodes is returned from the nodes accessor functions configured for the generator. * [Documentation] Default `extent` is `[[0, 0], [1, 1]]` rather than `null` as per source code.
The position outputs of the layout have been changed as follows:
node.x ↦ node.x0
node.dx ↦ node.x1 - node.x0
node.y ↦ node.y0
node.dy ↦ node.y1 - node.y0
link.dy ↦ link.width
link.sy ↦ link.y0 - link.source.y0 - link.width / 2
link.ty ↦ link.y1 - link.target.y0 - link.width / 2
This is more consistent with layouts in v4, and also simplifies drawing links;
a link’s source position is now [d.source.x1, d.y0] and its target position is
now [d.target.x0, d.y1].
|
From https://github.com/plotly/d3-sankey/tree/new
Looking good! 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.