Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Volcanoplot #57

Closed
VeraZab opened this issue Nov 29, 2018 · 5 comments · Fixed by #65
Closed

Test Volcanoplot #57

VeraZab opened this issue Nov 29, 2018 · 5 comments · Fixed by #65
Assignees

Comments

@VeraZab
Copy link
Contributor

VeraZab commented Nov 29, 2018

List all stylistic or functional issues here.
When done, change issue assignment to the component creator for them to fix the issues.

@mtwichan
Copy link
Contributor

Legend

  • It would look nicer if we used capitals for the names used in the legend.

  • Could we change of interest to another name like Point of Interest?

  • Maybe data could be Dataset?

@mtwichan
Copy link
Contributor

mtwichan commented Nov 30, 2018

Text and Inputs

  • It would look nicer if we added a nice little border around the text and inputs, to differentiate it more from the graph:
    volcano-layout

@mtwichan
Copy link
Contributor

Layout

  • Looks like there is an unnecessary scroll because of min-height in #app-page-content.
    scroll-volcano

@mtwichan
Copy link
Contributor

mtwichan commented Nov 30, 2018

Graph

@mtwichan
Copy link
Contributor

Code

  • Looks good. Would love to see an example that uses more of the props provided in the API for users that want to use this thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants