Add tests ideogram #182
Merged
Add tests ideogram #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bachibouzouk
force-pushed
the
add_tests_ideogram
branch
from
8e624f4
to
36e21a8
Compare
12 tasks
mkcor
reviewed
Feb 18, 2019
mkcor
reviewed
Feb 18, 2019
| @@ -500,6 +499,18 @@ Ideogram.propTypes = { | |||
| }), | |||
| }), | |||
|
|
|||
| /** | |||
| * Use perspective: 'comparative' to enable annotations between two chromosomes, | |||
| * either within the same organism or different organisms. Used for homology. | |||
There was a problem hiding this comment.
Suggested change
| * either within the same organism or different organisms. Used for homology. | |
| * either within the same organism or from different organisms. Used for homology. |
mkcor
reviewed
Feb 18, 2019
tests/test_ideogram.py
Outdated
| 'dash-bio/{}'.format(APP_NAME) | ||
|
|
||
|
|
||
| # below, write tests for initial conditions; they will most likely |
There was a problem hiding this comment.
I would take out this boilerplate.
Bachibouzouk
commented
Feb 18, 2019
tests/test_ideogram.py
Outdated
| # verify the existence of the brush | ||
| brush = selenium.find_elements_by_class_name('brush') | ||
| assert len(brush) == 1 | ||
| # selection = selenium.find_elements_by_class_name('selection')[0] |
There was a problem hiding this comment.
This test currently fails (issue #186), it has been commented out for the time being
Bachibouzouk
commented
Feb 18, 2019
|
|
||
| brush = selenium.find_elements_by_class_name('brush') | ||
| assert len(brush) == 1 | ||
| # verify that the selection of the brush was updated |
There was a problem hiding this comment.
Same as above (see #186)
|
Let's merge #187 into |
Remove deprecated selenium uses
|
|
||
| /** | ||
| * Use this prop in a dash callback to return annotationData when hovered. | ||
| * It is read-only, i.e. it cannot be used with dash.dependencies.Output but only with |
There was a problem hiding this comment.
Good idea specifying this -- it will avoid a lot of confusion down the line! :)
Co-Authored-By: Bachibouzouk <pierre-francois.duc@netplus.ch>
shammamah-zz
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fullfills part of #103
Props covered by the test
About
Description of changes
Before merging