Start tests for OncoPrint. #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shammamah-zz
approved these changes
Feb 20, 2019
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the #103 effort.
This PR contains only one test for the OncoPrint demo app (namely, clicking it takes you to the expected URL) and another test for the
showlegendprop of the OncoPrint component.Writing these tests revealed an error (inconsistency) in the naming convention for files related to OncoPrint, hence all the file renaming in this PR. We rely heavily on a strict naming convention, considering all the parsing we do, whether for components or demo apps based on them.