Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial merge: Dash sequence viewer #8

Merged
merged 121 commits into from
Nov 27, 2018
Merged

Conversation

shammamah-zz
Copy link
Contributor

@shammamah-zz shammamah-zz commented Oct 11, 2018

Dash Bio pull request

  • This is a new component
  • I am adding a feature to an existing component

Name and description of your component

Dash Bio component that can display a sequence of amino acids, with events like mouse selection, tooltips, and click events associated with a coverage (defined by the user). I also included a folder helpers that parses .fasta files (the most common file type I've found for amino acid sequences).

Main libraries used in component

  • Make sure you add links!

Before asking for a review

PR merging checklist

Please make sure you have done these things before asking for approval to finally merge.

  • Replace usage.py by app_[app name].py and put that file into the tests/dash folder.
  • Add your sample test data into the tests/sample_data folder. You should not need to add any files at the root level of the repository.
  • Address all comments in the code review.
  • Make sure you are up-to-date with the latest master: checkout the master branch with git checkout master, pull from latest master git pull, checkout to your branch git checkout your-branch, merge master into your branch git merge master. Resolve conflicts.
  • Test all existing apps and make sure they are not broken and make changes as necessary to make it work with the other apps.
  • Ensure that your requirements.txt is complete and contains the specific versions of all Python packages you are using (if you are running in a virtual environment and have only the necessary packages installed for your component, you can just use pip freeze > requirements.txt)
  • Run your application successfully in a virtual environment
  • Update/regenerate package-lock.json (run npm install)
  • Regenerate tarball (run python setup.py sdist, then copy dist/dash_bio-0.0.1.tar.gz into the top-level directory)
  • Ask for a final review and look for a 💃!

Shammamah Hossain added 30 commits September 18, 2018 16:33
… implement subpart selection and mouse selection.
… for coverage cannot work together for some reason.
…ile; reading contents of file will make application work when running on Heroku.
@mtwichan mtwichan temporarily deployed to dash-bio-test-pr-8 November 21, 2018 20:25 Inactive
@mtwichan mtwichan temporarily deployed to dash-bio-test-pr-8 November 21, 2018 20:56 Inactive
@mtwichan mtwichan temporarily deployed to dash-bio-test-pr-8 November 21, 2018 21:17 Inactive
@shammamah-zz
Copy link
Contributor Author

@VeraZab @wilzbach I made the changes you requested, please let me know if there is anything else!

@mtwichan mtwichan temporarily deployed to dash-bio-test-pr-8 November 22, 2018 20:35 Inactive
@mtwichan mtwichan temporarily deployed to dash-bio-test-pr-8 November 23, 2018 16:59 Inactive
@mtwichan mtwichan temporarily deployed to dash-bio-test-pr-8 November 23, 2018 19:35 Inactive
@mtwichan mtwichan temporarily deployed to dash-bio-test-pr-8 November 23, 2018 21:43 Inactive
@mtwichan mtwichan temporarily deployed to dash-bio-test-pr-8 November 23, 2018 21:54 Inactive
@mtwichan mtwichan temporarily deployed to dash-bio-test-pr-8 November 23, 2018 22:11 Inactive
@mtwichan mtwichan temporarily deployed to dash-bio-test-pr-8 November 27, 2018 17:49 Inactive
@shammamah-zz shammamah-zz merged commit 9a70caf into master Nov 27, 2018
Sprint 1 automation moved this from Getting ready for merge to Done Nov 27, 2018
@shammamah-zz shammamah-zz deleted the dash-sequence-viewer branch February 7, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Sprint 1
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants