Sequence viewer app improvements #87
Conversation
…n upon pressing submit button.
…reater than high.
There was a problem hiding this comment.
- The coverage data that's shown in the main sequence container (left panel) seems to be the same for all sequences. Should it be disabled for sequences where it does not apply?
- I wonder if the "Translated from" in the bottom of the middle panel should have just DNA and RNA as one would not need to translate protein to protein
- The output (right panel) of this translation, from DNA to protein for example, is shown as "Protein translated from DNA to" followed by the translated sequence. This seems a little confusing. I would suggest removing the "to" and changing this to "Protein translated from DNA: " followed by the actually sequence translation.
- I like the colors used to demarcate the different sections in the right panel. The only thing I see is that the colors take some focus off the content shown, so it'd probably be good to make the colors more transparent :)
…ll-width in sequence viewer.
|
I don't know what you think @VeraZab, but I would suggest rebasing on master (from https://github.com/plotly/dash-bio/branches I'm seeing that this branch is 5 commits behind master). |
|
@shammamah If you need help rebasing, I'm more than happy to help out! I admit I would prefer sitting side by side, but we can work it out remotely too. |
|
@mkcor note that this branch had master merged into it, so maybe a rebase could be messy.. |
Thanks, @VeraZab! In the meantime, I looked up these guidelines for contributing https://github.com/plotly/plotly.js/blob/master/.github/PULL_REQUEST_TEMPLATE.md#features-bug-fixes-and-others so I respect the preference for merging master rather rebasing once the PR is submitted (the issue doesn't arise so much if PR are kept small and fast; because then you rebase before pushing, and your PR gets reviewed before much would happen on master). |
| ) | ||
| def update_sel(slider_value, selOrCov, color): | ||
| def update_sel(slider_value, _, selOrCov, color, slider_input, |
|
@matthewchan15 Could you approve the changes @shammamah made upon your request? |
Addresses #58.