Add ignore to build:backends to aid discovery
#138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jest test files will throw warnings. Add example ignore pattern that will prevent this and give users a starting point to setup their own ignore without having to determine the format / escaping
alexcjohnson
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-docgen is set to run against all jsx and js files in
extract-meta.js, as a result any Jest test files will throw warnings.The boilerplate was my entrypoint to dash-generate-components so it took me an embarrassingly long time to find the ignore option.
This PR adds an example ignore pattern of a common Jest test filename pattern. Hopefully it also would give users a starting point to setup their own ignore without having to determine the format / escaping.
The more complex Jest default is here: https://jestjs.io/docs/configuration#testmatch-arraystring
Any question or concerns please just let me know, especially if I'm missing a part of your PR process. Cheers!