Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow numbers in project_shortname #144

Merged
merged 4 commits into from
May 26, 2022
Merged

Conversation

LiamConnors
Copy link
Contributor

No description provided.

@LiamConnors LiamConnors marked this pull request as draft May 24, 2022 13:35
@alexcjohnson
Copy link
Collaborator

Yes, definitely a good change! I don't know why the test failed, doesn't look related at all to your change but it would be good to figure out what's going on.

@LiamConnors
Copy link
Contributor Author

Investigating the 3.6 failure. The 2.7 failure I understand as fullmatch won't be available there. Is 2.7 something we would still need to support?

@alexcjohnson
Copy link
Collaborator

Yep, You can drop Py2. 🔪

@LiamConnors
Copy link
Contributor Author

Thanks @alexcjohnson. I removed the Python 2.7 tests. I updated the 3.6 test. It was checking in the /src directory for one of the .jl files but when I ran this locally that file is in /src/jl
https://github.com/plotly/dash-component-boilerplate/pull/144/files#diff-2cbedc61dab388ecb7f41cb83ec124ab9c1e9f297fe7ee2d548df29b3a6bb2bbR62
Updating the test resolved the test failure but I'm not 100% sure what the correct behaviour is there

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, the component generator has changed to use src/*.jl

Nice work! 💃

@LiamConnors LiamConnors marked this pull request as ready for review May 26, 2022 18:54
@LiamConnors LiamConnors merged commit c0bc329 into master May 26, 2022
@LiamConnors LiamConnors deleted the fix-module-name-check branch May 26, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants