Update webpack & co. #155
Update webpack & co. #155
Conversation
| @@ -14,7 +14,7 @@ | |||
| {%- endif %} | |||
| "main": "build/index.js", | |||
| "scripts": { | |||
| "start": "webpack-serve --config ./webpack.serve.config.js --open", | |||
| "start": "webpack serve --config ./webpack.serve.config.js --open", | |||
There was a problem hiding this comment.
Do people still use the demo? I wonder if we'd be better off removing it, so we only explicitly support testing components inside a Dash app.
There was a problem hiding this comment.
I don't think the demo is really useful, but I heard people use it to quickly test props and the lib may be used as raw react component also ?
For an exclusively dash component its probably better to test with usage.py as we got custom support for components props should make sure they actually work with the actual renderer.
There was a problem hiding this comment.
OK, we can leave it. Most of our own components the demo is either nonfunctional or has been deleted entirely, but if others use it we can leave it there.
| "react-dom": "^16.8.6", | ||
| "styled-jsx": "^3.2.1", | ||
| "style-loader": "^0.23.1", |
There was a problem hiding this comment.
| "style-loader": "^0.23.1", | |
| "style-loader": "^3.3.3", |
What's the pattern for which packages you updated and which you didn't? Let's try and get a few more of these updated while we're at it. I think if we use the latest style-loader and css-loader we just need to change the webpack config for css to:
use: ['style-loader', 'css-loader']
Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
|
Hmm need to re-enable circleci to clone the repo? |
Yes, the config are also using the old image and should be updated to use the |
No description provided.