Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content in tabs don't resize correctly #256

Closed
chriddyp opened this issue Aug 7, 2018 · 8 comments

Comments

@chriddyp
Copy link
Member

commented Aug 7, 2018

@chriddyp

This comment has been minimized.

Copy link
Member Author

commented Aug 11, 2018

another report here:
https://community.plot.ly/t/bar-chart-squashed-up-after-updating-drop-down/12647/2

we should update the docs with a link to this issue and/or encourage the callback method until this is resolved

chriddyp added a commit to plotly/dash-docs that referenced this issue Aug 13, 2018

chriddyp added a commit to plotly/dash-docs that referenced this issue Aug 13, 2018

🐛 document tab bugs so that there aren't any surprises for our users
- resize issue:
plotly/dash-core-components#256
- tab 2 by default issue:
plotly/dash-core-components#262

Once those issues are resolved, we should remove these items from the
docs
@chriddyp

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2018

This has now been documented in plotly/dash-docs#139. So, when this issue is fixed, we should update our documentation

chriddyp added a commit to plotly/dash-docs that referenced this issue Aug 13, 2018

chriddyp added a commit to plotly/dash-docs that referenced this issue Aug 13, 2018

🐛 document tab bugs so that there aren't any surprises for our users
- resize issue:
plotly/dash-core-components#256
- tab 2 by default issue:
plotly/dash-core-components#262

Once those issues are resolved, we should remove these items from the
docs

chriddyp added a commit to plotly/dash-docs that referenced this issue Aug 13, 2018

chriddyp added a commit to plotly/dash-docs that referenced this issue Aug 13, 2018

🐛 document tab bugs so that there aren't any surprises for our users
- resize issue:
plotly/dash-core-components#256
- tab 2 by default issue:
plotly/dash-core-components#262

Once those issues are resolved, we should remove these items from the
docs
@valentijnnieman

This comment has been minimized.

Copy link
Contributor

commented Sep 7, 2018

This was fixed in #279, and published in 0.28.3.

@jchaykow

This comment has been minimized.

Copy link

commented Sep 17, 2018

@valentijnnieman I just installed 0.28.3 and I'm still having this error. Any updates on this?

@valentijnnieman

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2018

@jchaykow Oh that's annoying! Could you copy paste a reproducible example here?

@jchaykow

This comment has been minimized.

Copy link

commented Sep 18, 2018

@valentijnnieman this one shows it:

import plotly.plotly as py
import plotly.graph_objs as go

import dash
import dash_core_components as dcc
import dash_html_components as html
from dash.dependencies import Input, Output, State

app = dash.Dash()

app.layout = html.Div([
    dcc.Tabs(id="tabs", children=[
        dcc.Tab(label='Tab two', children=[
                            html.Div([
                                html.Div([
                                    dcc.Graph(id = 'graph1')])
                            ], className="four columns"),
                            html.Div([
                                html.Div([
                                    html.Div(id='output-container'), 
                                    dcc.Graph(id = 'graph2',figure = dict(data = [dict(x=0, y=0)], layout = dict(height = 850)))
                                ])
                            ], className="four columns")
                        ]), 
        dcc.Tab(label='Tab three', children=[
                            html.Div([
                                html.Div([
                                    dcc.Graph(id = 'graph4')])
                            ], className="four columns"),
                            html.Div([
                                html.Div([
                                    html.Div(id='output-container1'), 
                                    dcc.Graph(id = 'graph5', figure = dict(data = [dict(x=0, y=0)], layout = dict(height = 850)))
                                ])
                            ], className="four columns")
                        ])
                    ])
                ])

if __name__ == '__main__':
    app.run_server(debug=True)

Versions:

dash==0.26.5
dash-colorscales==0.0.4
dash-core-components==0.28.3
dash-html-components==0.8.0
dash-renderer==0.11.2
@valentijnnieman

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2018

Thanks @jchaykow!

It looks like something went wrong when merging in master, and the fix was not included. It was probably my fault, I merged and published on a Friday and I was sick with a fever. Apologies! PR #306 should fix it again.

Dash - Stable and Extensive Core Component Libraries automation moved this from Done to In progress Sep 18, 2018

@jchaykow

This comment has been minimized.

Copy link

commented Sep 18, 2018

@valentijnnieman ah yea, happens to the best of us. Thanks for following up!

@chriddyp chriddyp closed this Sep 24, 2018

Dash - Stable and Extensive Core Component Libraries automation moved this from In progress to Done Sep 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.