Fixes #143, close-bilkent to cose-bilkent; fixes #119, added fcose layout #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexcjohnson Looking at the diff here, really feel like we should do something like the |
xhluca
approved these changes
Aug 16, 2021
| @@ -633,7 +633,7 @@ Cytoscape.propTypes = { | |||
| 'grid', | |||
| 'breadthfirst', | |||
| 'cose', | |||
| 'close-bilkent', | |||
| 'cose-bilkent', | |||
There was a problem hiding this comment.
is that the only line you modified before running npm run build? just making sure :)
There was a problem hiding this comment.
yes and in a few other places that were mostly documentation. I tested it by setting the layout to cose-bilkent and it works.
kinimesi
changed the title
|
Fixes #165 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Description of changes
Fixes #143, replaced close-bilkent with cose-bilkent
Pre-Merge checklist
npm run build:all.Reference Issues
Closes #143