Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental: microbundled react-cytoscapejs #180

Closed
wants to merge 2 commits into from

Conversation

akx
Copy link

@akx akx commented Jul 14, 2022

About

As requested by @alexcjohnson in plotly/react-cytoscapejs#99 (comment) , this pulls in the plotly/react-cytoscapejs#99 version of react-cytoscapejs and adds cytoscape as a direct dependency (as it is a peer dependency of react-cytoscapejs going forward).

I ran npm run build:all and tried some of the demos/ – everything seems to work just fine.

  • 👉 This PR should not be merged as-is, though, since the package.json specifier for react-cytoscapejs is not a published version. (That's why this is left as a draft.)

Description of changes

Please see above.

Pre-Merge checklist

  • The project was correctly built with npm run build:all.
  • If there was any conflict, it was solved correctly.
  • All changes were documented in CHANGELOG.md.
  • All tests on CircleCI have passed.
  • All Percy visual changes have been approved.
  • Two people have 💃'd the pull request. You can be one of these people if you are a Dash Cytoscape core contributor.

Reference Issues

@akx
Copy link
Author

akx commented Sep 5, 2022

Merged in plotly/react-cytoscapejs#99.

@akx akx closed this Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant